On Wed, 4 Aug 2021, Jeremy Drake via Mingw-w64-public wrote:

This can be done either by number, or by name.  Most names are from the
documentation for LINK.EXE's /SUBSYSTEM option, but a few were made up
based on the constants and documentation on MS's PE Format document.
---
I wasn't sure about using strcasecmp, but I grepped and gendef uses it
without a configure check, so it must be relatively safe...

It seems so yes; strcasecmp is part of POSIX (so it should be available on unix), and mingw provides it too. However the standard says that you should be including <strings.h> to use it, not the regular <string.h>. But then again, gendef doesn't seem to be including that header either...

As for the patch itself, it seems fine to me - I presume the code is written to match the surrounding coding conventions and all that (I didn't doublecheck).

// Martin



_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to