On Mon, 6 Sep 2021, Patrick Northon wrote:
Yes the indentation is funky because the original has one level with a tab character and spaces for the rest in some parts. I see you have submitted a patch to fix this.
Yes - hopefully someone will approve it soon, and I'd land it, then you can reapply your changes on top of that. As for why git didn't manage to apply your patch from the attachment, I don't quite know though.
The adjustment is expected in all cases except a true zero, which is why I set the exponent to 3 in __pformat_xldouble in that case. Beforehand, only in 2 cases would it not adjust the exponent by 3: for a true zero or an unnormal value with unlimited precision. In the later case, afaik, these are invalid values since 1987.
It is adjusted by 3 because the leading digit emitted is a 4 bits digits, while the leading digit in a long double is 1 bit, so we have to adjust the exponent.
If you prefer, I could put the exponent adjustment in __pformat_xldouble instead.
I think that might be a bit more readable, yes. I guess I'll have to sit down and trace the implementation to fully understand what happens throughout the code if I that form of the patch doesn't make it clearer.
// Martin _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
