在 2021-09-15 17:32, Steve Lhomme 写道:
Hi,

On 2021-09-13 18:21, Biswapriyo Nath wrote:
* C style comment please.

// is available in C since C99. Also I counted 145 such comments in the mingw 
headers.


Some of them are C++ code (e.g. in `gdiplus/`), some of them are too old and nobody has complained about them (e.g. in `dssec.h`), and some of them are imported from other projects (e.g. in `windowscontracts.h`). We still have to maintain C89 conformance, so please stick with C89 comments (as well as prohibition of trailing commas, etc.).


* I can not understand why "some of the arguments are replaced with void*".

These are methods using interfaces not defined in this patch. Only the methods we need (to handle the Acrylic effect in Windows 10) are added.



I'd say this is fine, but please mark such methods with `/* TODO */` for future 
rectification.


--
Best regards,
LIU Hao

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to