On Fri, 18 Feb 2022, LIU Hao wrote:

在 2/18/22 00:23, NightStrike 写道:

Adding unnecessary spam because of yet another poor choice of clang is
not something we should be catering towards.  Users can compile with
-Wno-strict-prototypes if it bothers them that much.



No this is not 'unnecessary'. In C the declaration `void* pthread_getevent();` is equivalent to `void* pthread_getevent(...);` despite lack of any means to get arguments (`va_start` requires a named parameter). Ancient code that predated ISO C used to define functions like

 int fputc();  /* declaration */

 int fputc()   /* definition*/
   int c;      /* arguments */
   FILE* fp;
 { /* ... */  }

so empty parentheses are there to provide compatibility, and leaving them there for now is not only not unnecessary, but totally incorrect in C.

Thanks, I pushed the patch then.

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to