On Sat, 5 Mar 2022, LIU Hao wrote:

在 2/20/22 04:27, Martin Storsjö 写道:
On Sat, 19 Feb 2022, Pali Rohár wrote:

Object files in archive libcrtdll_extra.a (which are linked into import library for crtdll.dll) cannot use msvcrt.h as it uses msvcrt.dll runtime
library.

Maybe clarify "uses", e.g. like this: "as it tries to load symbols at runtime from msvcrt.dll using GetProcAddress"

So avoid using msvcrt.h and __mingw_get_msvcrt_handle() in crtdll.dll
runtime and directly use "setlocale_codepage_hack" implementation.

This fixes building of lc_locale_func.c for libcrtdll_extra.a archive.
---

This patch looks reasonable to me.


Is there any progress about these patches? I haven't see them checked in so far.

It looked mostly good for me, but in patch 1/2 there was a commit message typo I wanted to have clarified before landing the patch - then as I haven't seen any reply to that, I've forgotten about the patches...

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to