On Thu, 22 Sep 2022, Martin Storsjö wrote:
On Thu, 22 Sep 2022, Alvin Wong via Mingw-w64-public wrote:
Thanks! Do you also need to add the prototype of __fastfail to intrin.h?
Hmm, apparently we do that for __debugbreak, although I'm not entirely sure
why that's needed here, since it's implemented in _mingw.h. I guess I could
add it there for consistency though - but I more see this as something that
can cause potential mismatches rather than help... (Also intrin.h does
include other headers, which end up including _mingw.h in the end anyway.)
I amended the patch locally to add the prototype there for consistency
too.
Also, there is a TODO comment in winnt.h about __fastfail, which I guess
should be made obsolete by this patch, is this right?
Yeah I think so. I'll amend the patch locally to remove that bit.
Any further comments or concerns about this patchset, or does it seem
acceptable to commit?
Also, what do you think about patch 4/4 - should I include it or leave it
out for now, as it's not used by the current fortification macros in the
headers (and thus can't practically be tested right now, and essentially
is dead code at this point)?
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
