在 2022/11/17 01:44, Biswapriyo Nath 写道:
WInSDK checks for _NT_TARGET_VERSION_WIN10_RS4 but it is not defined
or used anywhere. So, I think removing that cpp check would not harm
the use cases. Tested with pywin32 project.



It's because undefined macros are implicit zeroes in an #if condition.

Looking at 'mfapi.h': There are also references in comments about `_NT_TARGET_VERSION`, but the immediate #if checks beneath them all compare `NTDDI_VERSION` with `NTDDI_WIN10_RS*`. I think this sole reference to `_NT_TARGET_VERSION_*`, which are all undefined, is just an accidental typo.


Do you agree with this change:

   #if NTDDI_VERSION >= NTDDI_WIN10_RS4
   #define CREATE_WAITABLE_TIMER_HIGH_RESOLUTION 0x2
   #endif

or do you prefer `_WIN32_WINNT` to `NTDDI_VERSION` there?

--
Best regards,
LIU Hao

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to