On Sun, 20 Nov 2022, Pali Rohár wrote:
So at this point, do you think it's worth to add the complexity of manually
expanding the linker test (like what was removed in
6f53dbf6d423fab5a9fc6b3e4b07bdcf66d253b5), or should we just drop the test?
(Alternatively, a manually set --enable-image-base-compat or something like
that, can add the helper without a linker check.)
I think that manually defining __ImageBase symbol for new LD versions
should not cause issues.
Hmm, maybe - I could run some experimens with that to be sure about how
ld.bfd and lld behave in that case.
So when configure cannot detect if linker provides it (e.g. during
bootstrap) what about including it?
The problem is that I don't know offhand how to identify this situation in
autoconf (right now the AC_LINK_IFELSE flat out errors out, so we'd
probably need to inspect some autoconf internal variable before we know if
we can try to do the linker test).
In my case, every single of my builds are clean bootstrapped without any
preexisting crt (so this isn't an odd corner case, but in many settings,
this is the norm) - so I'd end up with the extra compat code in all my
builds, even if I'm using the very newest everything. So I'd kinda prefer
to have the default go the other way.
My own opinion is simply that we should be free to drop support for such
old tools.
I'm not a fan of thoughtlessly dropping support for old versions whenever
things get annoying, but we overall probably don't even know if our things
work with full binutils+gcc versions from back then, and in this case, the
affected versions really are very old.
Alternatively, I can write a patch to replace the configure check with the
same kind of manual check code that we used before. It worked fine for us
from 2018 to 2021, so it's probably robust enough, even if it of course is
simpler to have no test at all.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
