On Tue, 31 Oct 2023, LIU Hao wrote:
在 2023-10-31 21:37, Martin Storsjö 写道:
Yes, this is what I meant. The fact that Windows Store apps wouldn't be
getting the modern codepath with GetTickCount64, but unconditonally be
usin the old fallback codepath of using QueryPerformanceCounter,
doesn't seem too bad, so I think that's acceptable.
I suspect no further patch is needed?
Pretty much, yeah.
There is still a minor issue: When a module handle to KERNEL32 can't be
obtained, we are passing a null handle to `GetProcAddress()`, which then
attempts to look the target function in the current executable image, is
that desired?
Right - it would probably be safer/better style to check that, as I don't
see it documented that it would be ok to pass a null module to
GetProcAddress.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
