MSVC warns [1] against relative path in include directives, and
semaphore.h is already in the include path.
warning C4464: relative include path contains '..'
[1]:
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4464?view=msvc-170
windows.h is a system header and better placed at first, enclosed in
angle brackets.
Signed-off-by: Antonin Décimo <anto...@tarides.com>
---
The commit message has been improved compared to v1.
mingw-w64-libraries/winpthreads/src/barrier.h | 2 +-
mingw-w64-libraries/winpthreads/src/misc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/src/barrier.h
b/mingw-w64-libraries/winpthreads/src/barrier.h
index b1d80d1bb..5509678be 100644
--- a/mingw-w64-libraries/winpthreads/src/barrier.h
+++ b/mingw-w64-libraries/winpthreads/src/barrier.h
@@ -34,7 +34,7 @@
return EINVAL; \
} while (0)
-#include "../include/semaphore.h"
+#include "semaphore.h"
typedef struct barrier_t barrier_t;
struct barrier_t
diff --git a/mingw-w64-libraries/winpthreads/src/misc.c
b/mingw-w64-libraries/winpthreads/src/misc.c
index 800347854..83caf262f 100644
--- a/mingw-w64-libraries/winpthreads/src/misc.c
+++ b/mingw-w64-libraries/winpthreads/src/misc.c
@@ -20,8 +20,8 @@
DEALINGS IN THE SOFTWARE.
*/
+#include <windows.h>
#include "pthread.h"
-#include "windows.h"
#include "misc.h"
static ULONGLONG (*GetTickCount64FuncPtr) (VOID);
--
2.43.0
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
