On Thursday 29 February 2024 10:16:47 Martin Storsjö wrote:
> On Thu, 29 Feb 2024, Pali Rohár wrote:
>
> > On Wednesday 28 February 2024 23:24:25 Martin Storsjö wrote:
> > > On Wed, 28 Feb 2024, Pali Rohár wrote:
> > >
> > > > All commented lines refers to non-underscore aliases for underscored
> > > > variant of functions. Aliases for some reasons are not prevent, e.g.
> > > > because some aliases are defined in other files (CRT_fp10.c and
> > > > CRT_fp8.c).
> > >
> > > I don't understand what the second sentence here is saying, can you
> > > rephrase
> > > it?
>
> Ah, now I see, with s/prevent/present/, the sentence is a bit more
> understandable.
>
> > Ok, I will try to explain it a bit more. ADD_UNDERSCORE is a macro which
> > just adds a symbol alias. It does not export any new symbol.
> >
> > #define ADD_UNDERSCORE(symbol) symbol == _ ## symbol
> >
> > Symbol "fpreset" is already defined in CRT_fp10.c and CRT_fp8.c files as
> > an alias to the "_fpreset" symbol.
> >
> > So ADD_UNDERSCORE(fpreset) should not be added into msvcrt-common.def.in
> > because same job is already done by __attribute__((alias("_fpreset"))).
>
> Thanks, that's more understandable :-)
>
> >
> > > > ---
> > > > mingw-w64-crt/def-include/msvcrt-common.def.in | 15 ++++++++-------
> > > > 1 file changed, 8 insertions(+), 7 deletions(-)
> > > >
> > >
> > > > @@ -134,13 +135,13 @@ ADD_UNDERSCORE(y0)
> > > > ADD_UNDERSCORE(y1)
> > > > ADD_UNDERSCORE(yn)
> > > > ADD_UNDERSCORE(chgsign)
> > > > -;scalb
> > > > +ADD_UNDERSCORE(scalb)
> > >
> > > This change here is, accidentally?, actually adding the alias even though
> > > it
> > > was supposed to be commented out?
> > >
> > > // Martin
> >
> > Ah, it should not be there. My attempt was to cleanup comments without
> > any functional change. But all those parenthesis, semicolons and pluses
> > in diff make me hard to miss some accidental changes.
>
> Yep. I'd be fine with the patch with the commit message typo fixed (or with
> the more verbose version), and this typo here fixed as well.
>
> // Martin
Ok, do you need me to resend this patch? Or would you fix this one
missing semicolon during applying patch?
And... I do not know how to better write the commit message, so I would
be happy if give me example of how to rephrase it.
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
