rand is not random enough and may lead to clashing temporary directories
with multiple parallel link processes as it was observed on Rust's CI.
It can be reproduced with these commands (run them all in without long pauses):
for n in {1..15000}; do rm -f lib/libLLVMAVRAsmParser.a && \
ar qc lib/libLLVMAVRAsmParser.a
lib/Target/AVR/AsmParser/CMakeFiles/LLVMAVRAsmParser.dir/AVRAsmParser.cpp.obj
&& \
ranlib.exe lib/libLLVMAVRAsmParser.a; done &
for n in {1..15000}; do rm -f lib/libLLVMSparcCodeGen.a && \
ar qc lib/libLLVMSparcCodeGen.a
lib/Target/Sparc/CMakeFiles/LLVMSparcCodeGen.dir/*.obj && \
ranlib.exe lib/libLLVMSparcCodeGen.a; done
echo "done"
fg
Before the patch it will fail with an error: ranlib.exe: could not create
temporary file whilst writing archive: no more archived files.
The changes in this patch were proposed by Josh Stone on Rust's Zulip server
and I was asked to forward it.
Co-Authored-By: Josh Stone <jist...@redhat.com>
Signed-off-by: Mateusz Mikuła <mati...@gmail.com>
---
mingw-w64-crt/misc/mkstemp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mingw-w64-crt/misc/mkstemp.c b/mingw-w64-crt/misc/mkstemp.c
index 6b327f2fc..1698f49f4 100644
--- a/mingw-w64-crt/misc/mkstemp.c
+++ b/mingw-w64-crt/misc/mkstemp.c
@@ -1,3 +1,4 @@
+#define _CRT_RAND_S
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
@@ -25,6 +26,7 @@
int __cdecl mkstemp (char *template_name)
{
int i, j, fd, len, index;
+ unsigned int r;
/* These are the (62) characters used in temporary filenames. */
static const char letters[] =
"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
@@ -45,7 +47,8 @@ int __cdecl mkstemp (char *template_name)
*/
for (i = 0; i >= 0; i++) {
for(j = index; j < len; j++) {
- template_name[j] = letters[rand () % 62];
+ if (rand_s (&r)) return -1;
+ template_name[j] = letters[r % 62];
}
fd = _sopen(template_name,
_O_RDWR | _O_CREAT | _O_EXCL | _O_BINARY,
--
2.43.0.windows.1
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
