On Tue, 25 Jun 2024, Pali Rohár wrote:

---
mingw-w64-crt/lib-common/ucrtbase.def.in | 194 +++++++++++------------
1 file changed, 95 insertions(+), 99 deletions(-)

diff --git a/mingw-w64-crt/lib-common/ucrtbase.def.in 
b/mingw-w64-crt/lib-common/ucrtbase.def.in
index 99c8ad7663e2..d8ab325011b0 100644
--- a/mingw-w64-crt/lib-common/ucrtbase.def.in
+++ b/mingw-w64-crt/lib-common/ucrtbase.def.in
@@ -1400,7 +1400,7 @@ _o__strtof_l
_o__strtoi64
_o__strtoi64_l
_o__strtol_l
-_o__strtold_l
+F_ARM_ANY(_o__strtold_l) ; Can't use long double functions from the CRT on x86
_o__strtoll_l
_o__strtoui64
_o__strtoui64_l

Some more comments, even if I already pushed the set; I haven't really bothered touching all these internal/unused exports before (how do these differ from the usual non-prefixed ones anyway?) as nothing really is using them, but I guess it doesn't matter much either way, and I guess it makes it easier to check things for consistency.

@@ -2174,21 +2174,21 @@ acos
F_NON_I386(acosf)
acosh
acoshf
-acoshl F_X86_ANY(DATA)
+F_ARM_ANY(acoshl) ; Can't use long double functions from the CRT on x86

Also contrary to what the commit message made it sound like, most of these functions were already skipped on x86, but by marking the functions as DATA, while it's arguably more correct/consistent to omit them entirely like this patch does.

But just for context - this patch shouldn't have much of a practically observable effect, that aspect was already fixed long ago, this just makes it consistent with this new pattern for doing it.

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to