On Monday 19 August 2024 23:31:33 Martin Storsjö wrote:
> On Fri, 16 Aug 2024, Pali Rohár wrote:
>
> > List of symbols in ucrtbase.def.in and ucrtbased.def.in are very similar.
> > So move them into one common file ucrtbase-common.def.in and based on
> > DEF_DEBUG definition choose if the symbol list is for debug ucrtbased.dll
> > or release ucrtbase.dll library.
> > ---
> > ...ucrtbase.def.in => ucrtbase-common.def.in} | 315 +-
> > mingw-w64-crt/lib-common/ucrtbase.def.in | 2666 +---------------
> > mingw-w64-crt/lib-common/ucrtbased.def.in | 2712 +----------------
> > 3 files changed, 209 insertions(+), 5484 deletions(-)
> > copy mingw-w64-crt/lib-common/{ucrtbase.def.in => ucrtbase-common.def.in}
> > (87%)
> > rewrite mingw-w64-crt/lib-common/ucrtbase.def.in (99%)
> > rewrite mingw-w64-crt/lib-common/ucrtbased.def.in (99%)
>
> Thanks, this patch looks fine (I presume you've checked that it still
> produces the exact same list of symbols as before).
Yes, I checked it by manually calling cpp on def.in file and comparing
sorted output before and after.
> However, I'm unable to apply it (git thinks the patch is corrupted). Is this
> perhaps due to the use of format-patch options like -C/-M for detecting
> copies/moves here? Can you send a regular patch without those options? That
> will of course be much bigger and more annoying here on the mailing list -
> or do you have a public repo somewhere, where I could grab a copy of the
> commit as-is?
>
> // Martin
This change depends on other changes from UCRT patch series which is on
the list. So I'm not sure if you have applied it before or not. I think
that without them this change would not apply.
And yes, I have generated this change with -B -D. I can send a version
without -B -D if you want.
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
