On 22.08.2024 12:24, Martin Storsjö wrote:
This reverts parts of 52c98b1273a61b7a3e1fc93142fa4b5e4c3ee5ab.
While powf indeed is available in UCRT on i386 too, it's missing
in Wine's i386 ucrtbase.dll (as of Wine 9.15). This probably stems
from the same mistake originally. (Most of the float math functions,
suffixed with -f, are unavailable in the i386 UCRT, but powf is
available.)
Thus, to allow built executables to run on current Wine versions,
avoid linking against this function, as a temporary workaround.
After a grace period, to let fixed versions of Wine become more
widely available, we can revert this, to link against powf
on i386 too.
At that point, we can stop including math/powf.c in src_ucrtbase32
in Makefile.am too.
Signed-off-by: Martin Storsjö <[email protected]>
---
A fix for Wine was submitted in
https://gitlab.winehq.org/wine/wine/-/merge_requests/6336.
The change in 52c98b1273a61b7a3e1fc93142fa4b5e4c3ee5ab only
broke an uncommon case, when linking directly against ucrtbase,
rather than ucrt, as the commit only changed ucrtbase.def.in, but
not api-ms-win-crt-math-l1-1-0.def.in.
However, rather than updating api-ms-win-crt-math-l1-1-0.def.in in
sync with that change, revert the changes to ucrtbase.def.in (now
ucrtbase-common.def.in) temporarily, and add comments about why
we want to keep this marked like this, for now.
We can probably remove this Wine specific workaround after e.g.
a year or so.
Looks good to me.
Thanks,
Jacek
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
