On Wednesday 28 August 2024 19:39:18 Pali Rohár wrote:
> On Wednesday 28 August 2024 14:17:08 Martin Storsjö wrote:
> > On Wed, 28 Aug 2024, LIU Hao wrote:
> >
> > > 在 2024-08-28 03:15, Pali Rohár 写道:
> > > > -BOOL WINAPI __dyn_tls_init (HANDLE, DWORD, LPVOID);
> > > > -
> > > > -BOOL WINAPI
> > > > +static void WINAPI
> > > > __dyn_tls_init (HANDLE hDllHandle, DWORD dwReason, LPVOID lpreserved)
> > > > {
> > >
> > > `__dyn_tls_init()` has external linkage in Microsoft CRT, so we had
> > > better not declare it as `static`.
> >
> > I agree it might be safest or most flexible to keep it exported - although I
> > don't see a very large need for it; our object files aren't usually
> > interchangeable with MSVC toolchain produced ones anyway, and I'm not sure
> > that __dyn_tls_init() is a "public" interface we need to support.
> >
> > But retaining it as an external symbol still probably is safest.
> >
> > The rest of the patch seems ok.
> >
> > // Martin
>
> I did not know this. I agree with you that in this case we should have this
> symbol visible.
If you are fine with this change, would you apply this change with
removed static keyword to have symbol visible?
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
