On Wed, 4 Dec 2024, LIU Hao wrote:
在 2024-12-04 03:52, Pali Rohár 写道:
This feels like a typo - I presume it should say "in DllMain/DllEntryPoint
or in functions called _by_ DllMain/DllEntryPoint"? I see that the
existing
case in crtexe.c has a similar typo.
I copied the comment from the crtexe.c. It looks like that there is
missing some preposition (from? in? by?) but I do not know which one is
the correct one in english. So I would let it to you or other people to
fix it. So feel free to modify the comment at both places.
The change itself seems ok to me.
To me 'in' and 'by' sound like direct calls so I vote for 'from'.
(The difference between 'in' and 'by' is like 'called in a scope' and 'called
by something else'.)
Ok, fair enough - I pushed a fix for the existing comment, adding "from".
I'll amend this patch to add a "from" before pushing as well.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
