On Fri, 4 Apr 2025, Martin Storsjö wrote:
On Fri, 4 Apr 2025, Jacek Caban wrote:
From: Billy Laws <blaw...@gmail.com>
Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---
mingw-w64-headers/crt/math.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mingw-w64-headers/crt/math.h b/mingw-w64-headers/crt/math.h
index dc1599ed5..58636984e 100644
--- a/mingw-w64-headers/crt/math.h
+++ b/mingw-w64-headers/crt/math.h
@@ -824,7 +824,7 @@ __mingw_choose_expr (
\
__CRT_INLINE long double __cdecl logbl (long double x)
{
-#if defined(__arm__) || defined(_ARM_) || defined(__aarch64__) ||
defined(_ARM64_)
+#if defined(__arm__) || defined(_ARM_) || defined(__aarch64__) ||
defined(_ARM64_) || defined(__arm64ec__) || defined(_ARM64EC_)
__mingw_ldbl_type_t hlp;
int lx, hx;
--
Isn't this function within an #if 0 block? It seems to have been so since
ae945cc331 in 2014.
That said I do seem to have touched this while filling in things for aarch64,
so it's probably ok to keep doing that for arm64ec too if you feel like it,
for consistency, but it's probably safe to say that the code here is unused
for the last 11 years, and probably not tested for the arm/aarch64 cases at
all.
Yeah this seems to use the __mingw_ldbl_type_t struct which interprets an
80 bit float, so this certainly is wrong for the existing arm/aarch64
cases.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
