On Saturday 24 May 2025 19:32:31 LIU Hao wrote: > 在 2025-5-24 18:29, Pali Rohár 写道: > > On Saturday 24 May 2025 18:25:35 LIU Hao wrote: > > > 在 2025-5-24 18:12, Pali Rohár 写道: > > > > > And it deduplicated 496 def files. What do you think about it? Just a > > > > > robotic change and can decrease number of def files which needs to be > > > > > maintained. > > > > > > I don't have a specific opinion on this change. > > > > Well, this change is only about files which have exactly same content. > > > > That's exactly the question: Because some of the DEFs are in lib-common and > some are in lib32, then where does X belong? We have to make a decision > here, and possibly in the future, also have to move existent files around.
I agree with you. I think that currently it is the worst what can be. For those 496 def files we have one common file in lib-common for x64, arm32 and arm64 and then copy of that file in lib32 for i386. IMHO ether there should be no lib-common and copy of each file in lib32, lib64, libarm32 and libarm64. Or the should be just one file in lib-common. So yes, as you wrote it needs to be decided where does X belong. In this my change I proposed to deduplicate also lib32 into lib-common, like it is already for lib64+libarm32+libarm64. > I am personally not a fun of reusing code, especially code that is riddled > with inconsistencies from an external source. Other option could be drop lib-common and copy all files from lib-common to lib64, libarm32 and libarm64. Side note: I did the cleanup and unification of msvcrt.def.in for all archs and it helped me a lot to figure out which symbol is available for which arch via the F_ macros. And that make it easier to define emulation symbol in the correct Makefile.am section. But this mostly applies only for CRT libraries, not generally for all other WinAPI libs. _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
