On Sun, 15 Jun 2025, Pali Rohár wrote:
Both msvcrt and UCRT ABI uses for off_t-based function without any suffix in their name the 32-bit long off_t type for both 32-bit and 64-bit architectures.
The non-English word order makes this sentence very hard to parse. Right now, this sentence reads "X uses for Z Y" - which isn't how such things are said in English, and makes it very hard to spot which part of the long sentence belongs to the "for Z" part and which part is the "Y" part. The proper word order would be "X uses Y for X".
Other than that, I didn't really spot any issue with it by reading it through. And a run through the CI looked fine.
But given the fallout from the stat patches, I wonder if we should have some sort of test that tries to call all the functions that are involved in this patchset, that we could test build - ideally for all CRTs, but in practice at least for msvcrt+ucrtbase+ucrt, to make sure we don't miss any.
// Martin _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
