On Wednesday 25 June 2025 11:08:55 Martin Storsjö wrote: > We already have a wrapper function hypot() in math/hypot.c (which > handles special cases of inputs, then invokes _hypot() internally). > This wrapper function is included in all msvcr* import libraries > already. By providing an alias, the import library ended up providing > two symbols with the same name within the same library - making it > unclear which one the linker ends up using. > > This fixes the cabs testcase on i686 on msvcrt, with LLVM tools. > > Signed-off-by: Martin Storsjö <mar...@martin.st> > --- > mingw-w64-crt/def-include/crt-aliases.def.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mingw-w64-crt/def-include/crt-aliases.def.in > b/mingw-w64-crt/def-include/crt-aliases.def.in > index 3c4f7c352..fa1d532a2 100644 > --- a/mingw-w64-crt/def-include/crt-aliases.def.in > +++ b/mingw-w64-crt/def-include/crt-aliases.def.in > @@ -232,7 +232,7 @@ ADD_UNDERSCORE(wcsupr) > #ifdef UCRTBASE > ; hypot is natively exported from UCRT > #else > -ADD_UNDERSCORE(hypot) > +; ADD_UNDERSCORE(hypot) ; We provide a wrapper hypot() function around > _hypot()
nit: like in other changes in this file, what about completely removing the "ADD_UNDERSCORE(hypot)" from line (not just commenting it)? E.g.: +; _hypot function is provided by math/hypot.c > #endif > ADD_UNDERSCORE(j0) > ADD_UNDERSCORE(j1) > -- > 2.43.0 > _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
