On Wed, 25 Jun 2025, Pali Rohár wrote:
On Wednesday 25 June 2025 11:05:19 Martin Storsjö wrote:
On Tue, 24 Jun 2025, Pali Rohár wrote:
I see. How insane. msvcrt has _fseeki64() function but does not have
_ftelli64() function. This change should address this issue:
diff --git a/mingw-w64-crt/def-include/crt-aliases.def.in
b/mingw-w64-crt/def-include/crt-aliases.def.in
index 1edb042baf94..3c4f7c352132 100644
--- a/mingw-w64-crt/def-include/crt-aliases.def.in
+++ b/mingw-w64-crt/def-include/crt-aliases.def.in
@@ -321,10 +321,11 @@ stat64i32 == _stat64i32
#if defined(NO_FIXED_SIZE_64_ALIAS) && !defined(NO_FSTAT64_ALIAS)
fstat64 == _fstat64
#endif
+#ifdef WITH_FSEEKO64_ALIAS
+fseeko64 == _fseeki64
+#endif
#else
fstat64 == _fstat64
-#endif
-#ifndef FIXED_SIZE_SYMBOLS
fseeko64 == _fseeki64
ftello64 == _ftelli64
#endif
diff --git a/mingw-w64-crt/lib-common/msvcrt.def.in
b/mingw-w64-crt/lib-common/msvcrt.def.in
index 1fa3ffc9ad3a..7b903360acfe 100644
--- a/mingw-w64-crt/lib-common/msvcrt.def.in
+++ b/mingw-w64-crt/lib-common/msvcrt.def.in
@@ -1930,5 +1930,6 @@ F_I386(_libm_sse2_tan_precise)
#endif
#if defined(__arm__) || defined(__aarch64__)
#define USE_WCSTOK_S_FOR_WCSTOK
+#define WITH_FSEEKO64_ALIAS
#endif
#include "crt-aliases.def.in"
This does seem to work.
In which of the existing patches do you want to squash this change? Or does
it go as a separate patch somewhere?
Doing fixup will cause conflicts with existing patches. So the easiest
thing is to apply this change on top of all of them.
Ok, fair enough, I'll add that as a separate commit then.
With this change, this patchset seems to pass all the test configurations,
and I didn't see anything to object to in there, so I'll go ahead and push
it.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
