On Thu, 9 Oct 2025, Pali Rohár wrote:
Pali Rohár (6):
headers: Guard time functions for CRT build
crt: Provide emulation of _ftime64 function
crt: Fix return type for POSIX ftime function
crt: Provide emulation of _gmtime64 function
crt: Provide emulation of _mkgmtime32 and _mkgmtime64 functions
crt: Extend t_time test for ftime, _gmtime64, _mkgmtime64, _ctime64
and _wctime64
Which git version does this patchset apply cleanly to?
I extract these mails and try to apply them with "git am -3", but I get
conflicts on Makefile.am. I try applying it on a few older revisions of
Makefile.am, but "git am -3" still fails. So I have to manually apply some
of the patches with "patch", which also is error prone and fiddly when
those patches also add new files that weren't tracked by git before.
All in all - just to even apply this patchset to git, so I can look at it,
I used up all the time (and energy) I had to spend on reviewing it right
now, so now I have no time left to actually review it.
When sending a patchset, the very least you can do would be to at least
rebase it on latest git master before sending it, so that it applies - so
I don't have to play guessing games on which version it maybe can be
applied.
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public