On Sat, 25 Oct 2025, Pali Rohár wrote:

Changes were applied on top of the 482b0b73f3ec6317f7bfa1fb277dfd9fe75f2971

Pali Rohár (6):
 crt: Fix support for mingw_pformat %C and %S
 crt: Fix support for mingw_pformat %c and %s in wide wprintf
 crt: Add tests for printf format %c/%C and %s/%S
 crt: Fix __pformat_wputchars() for swprintf
 crt: Add support for mingw_pformat %Z, %hZ, %lZ, %wZ
 crt: Add tests for printf format %Z

I had a few comments on commit message and comment wordings here.

Other than that, this looks reasonable to me. I think this is the most consistent way forward.

However in practice, there's a moderately high chance that this will break existing code (for all the code that is built with __USE_MINGW_ANSI_STDIO=1, which is the default for most configurations with msvcrt.dll, and with UCRT you'll also get this if you e.g. include libstdc++ headers). Like, I'm quite sure that this will break some user's code.

But on the other hand, our current state is inconsistent, so this does make things better.

What do Liu Hao and Jacek think about it?

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to