On Saturday 28 February 2026 11:06:25 LIU Hao wrote: > 在 2026-2-27 22:29, LIU Hao 写道: > > 在 2026-2-25 04:00, Pali Rohár 写道: > > > Hello, in attachment I'm sending documentation changes for 32-bit x86 > > > advapi32.dll library and fixes of two symbols. It is same form as what I > > > have done for kernel32.dll and ntdll.dll in past. Kirill run the CI > > > tests with these (and also other changes), they passed: > > > https://github.com/maiddaisuki/mingw-w64/actions/runs/22307392638 > > > > > From 0fad143f7937bf1a881e2fe53573fb0641d36c53 Mon Sep 17 00:00:00 2001 > > > From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <[email protected]> > > > Date: Sun, 25 Jan 2026 19:01:38 +0100 > > > Subject: [PATCH 1/3] crt: Fix advapi32 SaferiRegisterExtensionDll symbol > > > > > > Ordinal-only symbol needs to be declared with NONAME, like current > > > version of gendef is doing it. > > > Ordinal @1000 in 32-bit x86 advapi32.dll file has name > > > SaferiRegisterExtensionDll according to: > > > https://www.geoffchappell.com/studies/windows/win32/advapi32/history/ords61.htm > > > --- > > > mingw-w64-crt/lib32/advapi32.def | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This is not an authoritative source of such information. However, this > > name can be found in Microsoft advapi32.pdb, so it's correct. (You may > > use Visual Studio to download PDB of a system DLL from Microsoft Symbol > > Server.) > > > > I will take a look into the third patch tomorrow. > I have pushed this series of patches with some fixups in comments:
Ok, thanks! Just to note that more of those comment patterns I reused from previous lib32/kernel32.dll and lib32/ntdll.def changes, so probably similar grammar changes would be needed also for those two files. _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
