Hi LIU Hao, The \r characters do not come from the .def.in files — I checked and they use LF line endings. The issue is specific to building in a Cygwin environment, where the preprocessor emits \r characters in its output.
Please find the corrected patch attached as a plaintext file. Best regards, Liaiss On Thu, May 21, 2026 at 4:18 PM LIU Hao <[email protected]> wrote: > 在 2026-5-21 19:58, Liaiss Merzougue via Mingw-w64-public 写道: > > Hi, > > > > The following patch fixes a regression introduced by commit e128670e13 > > ("Merge lib32 def files into lib-common def.in files"). > > > > That commit merged lib32 and lib64 .def files into shared .def.in > files > > and added @N stdcall suffixes, relying on a sed substitution in > > Makefile.am to strip them for non-i386 targets. However, when building > > in a Cygwin environment, the preprocessor emits '\r' characters in its > > output, which prevents sed from matching the end of line — leaving the > > @N suffix intact in the generated .def files. > > Does it? Do those \r characters exist in .def.in files, because of > autocrlf of Git? > > The patch seems to have been corrupted by your mail client. If there's > need to send a new one, please > send it as a plaintext attachment. > > > > -- > Best regards, > LIU Hao > _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
