> This patch series cleans up and de-duplicates declarations in locale.h.

Hello, are there any comments other than concerns regarding guards used to 
expose _create_locale, _free_locale, _get_current_locale and 
_configthreadlocale?

I explained in previous replies that these changes will not break packages 
which unconditionally use _locale_t functions with msvcrt.dll.

I actually think these changes could further strengthen guards for _locale_t 
functions in locale.h from

```
#if __MSVCRT_VERSION__ >= 0x0800 || __MSVCRT_VERSION__ == 0x0600
```

to

```
#if __MSVCRT_VERSION__ >= 0x0800 || (__MSVCRT_VERSION__ == 0x0600 && 
_WIN32_WINNT >= 0x0600)
```

We already use equivalent guard for functions which take _locale_t argument. I 
think it makes sense that functions which manipulate _locale_t objects are only 
exposed when there are functions which can use them.

- Kirill Makurin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to