Hello, I checked these patches. For me it looks good, I have just few comments.
"[PATCH 05/13] crt: update logic in _configthreadlocale stub" Maybe switch statement would be better to describe all possible input argument? "[PATCH 08/13] crt: locale.h: re-group declarations [3/5]" "[PATCH 09/13] crt: locale.h: re-group declarations [4/5]" It looks suspicious if the libmsvcrt-os.a code in files _configthreadlocale.c, _create_locale.c, _free_locale.c and _get_current_locale.c contains "#define __MSVCRT_VERSION__ 0x0800". This define should be used exclusively for compiling libmsvcr80.a, not for libmsvcrt.a (or any other). I think that it is bad idea to redefine __MSVCRT_VERSION__ during compilation of mingw-w64. It is really needed? Because it is not explained in commit message why is this change, and my feeling is that it is not needed. mingw-w64-crt code is being compiled with flag -D__MSVCRT_VERSION__=0x0600 which is already covered by existing checks and should provide declarations of all those functions. Note that we have _CRTBLD macro which is already used in mingw-w64-headers to hide some symbols/functions. So we can use it also for defining symbols needed for mingw-w64-crt compilation (if needed). _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
