在 2026-8-26 18:13, Martin Storsjö 写道:
On Wed, 26 Aug 2026, LIU Hao wrote:在 2026-8-23 20:07, Pali Rohár 写道:This function is used only in the pesect.c file. --- mingw-w64-crt/crt/pesect.c | 4 +--- mingw-w64-crt/include/internal.h | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)I think these functions might be useful for user code. Does making them static save any bytes from linked executables?While I agree that they could be useful for user code in some cases, I don't think we should start exposing new helper functions randomly, especially without any specific good reason for it. (Just like we shouldn't just generally expand the subset of POSIX that we provide.)
That's fair enough. However this isn't a new function; it has been there for about twenty years, with external linkage. If user code references anything from pesect.c, it's likely to need this function anyway.
(Making it static might also make it eligible for inlining, which seems to save some bytes.) -- Best regards, LIU Hao
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
