LIU Hao wrote:
> 在 2026-9-2 18:31, Kirill Makurin 写道:
>> Hello, I would like to remind about these patches.
>>
>
> I'll take a look later.
Thanks!
> For the time being, Claude Sonnet 5 suggests these changes:
>
> HANDLE event = InterlockedExchangePointer ((void **) &mutex->Event,
> NULL);
>
> if (event != NULL) {
> - CloseHandle (mutex->Event);
> + CloseHandle (event);
> }
>
> free (mutex);
This is a nice catch! I originally passed `mutex->Event`, but they decided it
would be a good idea to atomically invalidate `mutex->Event` (this avoid vert
unlikely case when the same event handle is passed twice to `CloseHandle`), and
in a few cases I forgot to update calls to `CloseHandle`.
> /**
> * Obtain pointer to `WinpthreadsMutex` structure pointed to by `m`.
> *
> - * If `m` points to statically initialzied `pthread_mutex_t` object,
> + * If `m` points to statically initialized `pthread_mutex_t` object,
> * allocate `WinpthreadsMutex` structure and store its address in `*m`.
> *
> * On success, stores pointer to `WinpthreadsMutex` structure in `*wMutex`.
This one and other typos are also nice catches.
Will you be able to apply them on top of commits where they seem appropriate?
- Kirill Makurin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
