On Wed, 9 Sep 2026, LIU Hao wrote:

Thanks. Pushed now.

These changes broke building the "srt" library, thus breaking building VLC.

The srt library contains a header, https://github.com/Haivision/srt/blob/v1.5.7/common/win/wintime.h#L24-L31, which contains this:

#ifndef _TIMEZONE_DEFINED /* also in sys/time.h */
#define _TIMEZONE_DEFINED
struct timezone
{
    int tz_minuteswest; /* minutes W of Greenwich */
    int tz_dsttime;     /* type of dst correction */
};
#endif

After our headers now no longer define _TIMEZONE_DEFINED, we end up with a duplicate definition of the struct here.

I think the simplest and most pragmatic workaround would be to reinstate at least the "#define _TIMEZONE_DEFINED". We could also reinstate the ifdefs around it, to avoid conflicts if user headers may have defined it before us. But we can at least avoid duplicating it between the two headers, if one of them always include the other one.

// Martin



_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to