https://bugzilla.redhat.com/show_bug.cgi?id=1049550
--- Comment #2 from František Dvořák <val...@civ.zcu.cz> --- My observations: 1) using obsolete m4 macros in upstream (https://fedorahosted.org/FedoraReview/wiki/AutoTools) AC_PROG_LIBTOOL found in: LibRaw-0.15.4/configure.ac:10 It could be worth to let upstream know about it, and/or patch it locally. But it is just extra check and it is not required to fix that. 2) deleting of the .la files would be better written: find %{buildroot} -name '*.la' -delete But that's only cosmetic and not needed. 3) incorrect FSF address in LGPL license file No action is required for the package. It would be good to let upstream know about it. 4) executable bit in permissions of LICENSE.CDDL, LICENSE.LGPL 5) the file sizes and content mismatch LibRaw-demosaic-pack-GPL3-0.15.4.tar.gz and LibRaw-demosaic-pack-GPL2-0.15.4.tar.gz are OK (archive differs, but content is the same). LibRaw-0.15.4.tar.gz has different event content. I guess we can't do anything about it and it is not needed. Just keeping the sources the same as in native LibRaw package (as they already are)? 6) Btw. the "MinGW" means "Minimalist GNU Windows". The text "MinGW Windows %{pkgname} library" has de facto two "Windows" words. Maybe replace the "Windows" by "Win32"/"Win64"? Or there is used text "MinGW compiled example library for the Win32 target" in guidelines example... I think only "4)" is necessary to fix. The remaining issues are for considering. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fGzyOTmfWJ&a=cc_unsubscribe _______________________________________________ mingw mailing list mingw@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/mingw
