https://bugzilla.redhat.com/show_bug.cgi?id=1066559
František Dvořák <val...@civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |MODIFIED
CC| |val...@civ.zcu.cz
Assignee|nob...@fedoraproject.org |val...@civ.zcu.cz
Flags| |fedora-review?
--- Comment #1 from František Dvořák <val...@civ.zcu.cz> ---
Taking the review.
1) Since it is needed to regenerate the configure script anyway, I would vote
for drop the terrible autotools patch from original native package and patch
the sources instead to work with newer autotools, and regenerate everything.
Any opinion? (I'll attach patches for inspiration)
2) Using "LDFLAGS=-no-undefined" in the %build would override ldflags from
rpmbuild. I guess better would be a patch? Or using hack - add it to
libid3_la_LIBADD?
3) What is the reason for "check_PROGRAMS=" parameter for make?
4) This could be formulated better (but I'm not native English speaker):
"This is the MinGW tools, built for the win32 target."
It could be used something like: "This is the MinGW version of tools", "These
are the MinGW compiled tools", ...
5) cosmetic/silly (you can ignore :-)): double newlines before '%package -n
mingw...' could used everywhere in .spec
id3lib can use iconv for converting characters. But it would be hard to
convince configure to use it (there are some TRY_RUNs). Does id3lib work OK
with non-ASCII characters in id3 tags? (There is some replacement code for it,
so it is probably fine.)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=WPnGue2Tfs&a=cc_unsubscribe
_______________________________________________
mingw mailing list
mingw@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/mingw
