I've fixed the issue on trunk. However, I don't think that's what's causing
the segfault. There is a guard against empty WL messages on the client. Max,
What are you doing to reproduce the error?
regards,
Alan Alvarez
On Thu, Jun 24, 2010 at 1:26 AM, Alan Alvarez <aalva...@aliensoft.net>wrote:
> I'm thinking both are causing the issue. I might be able to take a
> look at it tomorrow.
>
> On 6/24/10, naveen akarapu <naveen.akar...@gmail.com> wrote:
> > Max
> >
> > I couldn't spend much time today, but I found where the message is being
> > built:
> >
> > trunk/mira-server/include/network/messages/MsgListWorkplaces.h:48
> > std::string response = "WL ";
> >
> > You can try removing the space. But really, I would like to see if the
> > message is necessary when there's no workplace associated with the user.
> > And, if this absence of workplace is being handled by client.
> >
> > Regards
> > Naveen
> >
> > On Wed, Jun 23, 2010 at 8:36 PM, naveen akarapu
> > <naveen.akar...@gmail.com>wrote:
> >
> >> Alan
> >>
> >> In the stack Max attached yesterday, I think he created a new user and
> >> tried to log in. Hence the user didn't have any workplace associated.
> >> Bytes
> >> transferred says 4.
> >>
> >> Regards
> >> Naveen
> >>
> >>
> >> On Wed, Jun 23, 2010 at 5:52 PM, Alan Alvarez
> >> <aalva...@aliensoft.net>wrote:
> >>
> >>> A WL message should be followed by a workplace ID.
> >>> regards,
> >>>
> >>> Alan Alvarez
> >>>
> >>>
> >>> On Wed, Jun 23, 2010 at 4:23 PM, Max Bossino
> >>> <m...@miragroupware.org>wrote:
> >>>
> >>>> Hi Naveen,
> >>>>
> >>>>
> >>>> On 23 Jun 2010, at 17:19, naveen akarapu wrote:
> >>>>
> >>>> Max
> >>>>
> >>>> I believe TEST TWO END might also have go through fine. The message
> just
> >>>> wasn't printed out. Segfault does it -- it eats up some of the
> messages
> >>>> in
> >>>> the out stream buffer. You can get all the outputs in gdb though.
> >>>>
> >>>> From the stack you provided yesterday, the segfault signal happened
> when
> >>>> the Workplace info is received by the client.It's the second message
> >>>> received from the server when you login. When I ran gdb, I created a
> >>>> breakpoint at
> >>>> *
> >>>> b AsioClient.cpp:176*
> >>>>
> >>>> and then looked at the value in current
> >>>> *p current *
> >>>>
> >>>> after the statement
> >>>>
> >>>> char* current = m_input_buffer;
> >>>>
> >>>>
> >>>> The first one, "LS\n", was fine. The second one, "WL \n", I felt may
> be
> >>>> carrying junk characters. So tried to set it zero.
> >>>>
> >>>>
> >>>> Hmm... Is there any way I can edit the "WL \n" so that I can test if
> >>>> that
> >>>> is what's causing the Segfault? It's odd that the message that fails
> >>>> includes a space, and the one that works doesn't.
> >>>>
> >>>> Please find attached the AsioClient.cpp file that I'm using (with my
> >>>> amendments), and the output of GDB when using the breakpoint you
> >>>> specified
> >>>> (which I don't think you will find very useful, but I thought I'd
> attach
> >>>> it
> >>>> anyway!).
> >>>>
> >>>> I also don't understand why the change to line 48 which you proposed
> >>>> does
> >>>> not fix the Segfault?
> >>>>
> >>>> Regards,
> >>>>
> >>>> Max Bossino
> >>>> Project Manager
> >>>> http://miragroupware.org
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> >>>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> >>>> lucky parental unit. See the prize list and enter to win:
> >>>> http://p.sf.net/sfu/thinkgeek-promo
> >>>> _______________________________________________
> >>>> Mira-development mailing list
> >>>> Mira-development@lists.sourceforge.net
> >>>> https://lists.sourceforge.net/lists/listinfo/mira-development
> >>>>
> >>>>
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> >>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> >>> lucky parental unit. See the prize list and enter to win:
> >>> http://p.sf.net/sfu/thinkgeek-promo
> >>> _______________________________________________
> >>> Mira-development mailing list
> >>> Mira-development@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/mira-development
> >>>
> >>>
> >>
> >
>
> --
> Sent from my mobile device
>
> regards,
>
> Alan Alvarez
>
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Mira-development mailing list
Mira-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mira-development
