Commit ID: 1005529999F77F915AE
CVSROOT: /cvs
Module name: src
Changes by: [email protected] 2015/04/11 22:03:33 UTC
Modified files:
bin/mksh : eval.c exec.c lex.c main.c sh.h syn.c tree.c
Log message:
SECURITY: fix integer overflows related to file descriptor parsing
bug initially found by Pawel Wylecial (LP#1440685)
additional bug found and suggested fix by enh (elliott hughes)
This commit also renames struct ioword.flag to ioflag to disambiguate
it from other members named “flag”, changes it to an unsigned type,
and packs ioflag and unit into shorts each, to make the struct smaller
(aligned even: 16 bytes on 32-bit systems) and reviews some of the
code involved in fd handling, though there wasn’t much to be found.
To generate a diff of this changeset, execute the following commands:
cvs -R rdiff -kk -upr1.166 -r1.167 src/bin/mksh/eval.c
cvs -R rdiff -kk -upr1.147 -r1.148 src/bin/mksh/exec.c
cvs -R rdiff -kk -upr1.198 -r1.199 src/bin/mksh/lex.c
cvs -R rdiff -kk -upr1.290 -r1.291 src/bin/mksh/main.c
cvs -R rdiff -kk -upr1.721 -r1.722 src/bin/mksh/sh.h
cvs -R rdiff -kk -upr1.99 -r1.100 src/bin/mksh/syn.c
cvs -R rdiff -kk -upr1.72 -r1.73 src/bin/mksh/tree.c