On Wed, Dec 05, 2018 at 04:53:20AM +0000, [email protected] wrote: > Gilles Chehade <[email protected]> wrote: > [...] > > > ascii_load_bounce_type(enum bounce_type *dest, char *buf) > > > { > > > if (strcasecmp(buf, "error") == 0) > > > - *dest = B_ERROR; > > > + *dest = B_FAILED; > > > else if (strcasecmp(buf, "warn") == 0) > > > - *dest = B_WARNING; > > > + *dest = B_DELAYED; > > > else if (strcasecmp(buf, "dsn") == 0) > > > - *dest = B_DSN; > > > + *dest = B_DELIVERED; > > > > > > the strcasecmp are not correct here > > > > > > > else > > > return 0; > > > return 1; > > > @@ -574,13 +574,13 @@ ascii_dump_bounce_type(enum bounce_type > > > char *p = NULL; > > > > > > switch (type) { > > > - case B_ERROR: > > > + case B_FAILED: > > > p = "error"; > > > break; > > > - case B_WARNING: > > > + case B_DELAYED: > > > p = "warn"; > > > break; > > > - case B_DSN: > > > + case B_DELIVERED: > > > p = "dsn"; > > > break; > > > > the dumped strings are not correct here > > Wouldn't that require a bump to SMTPD_ENVELOPE_VERSION?
not necessarily what you can do is have the load function recognize both strings but have the dump function only emit new strings. this way you have a transitional phase that we can retain until 6.6, and SMTPD_ENVELOPE_VERSION won't need a bump because we can safely assume that no one will have bounce envelope temp failing for over six months. -- Gilles Chehade @poolpOrg https://www.poolp.org tip me: https://paypal.me/poolpOrg -- You received this mail because you are subscribed to [email protected] To unsubscribe, send a mail to: [email protected]
