On Thu, Jul 18, 2013 at 05:12:07PM +0000, Martin Brandenburg wrote: > Hello, >
Hi, > [...] > > I thought it would be appropriate to change OpenSMTPD to reject empty > addresses; however, line 1513 of smtp_session.c specifically accepts > empty addresses. What is the use case of that? Does the RFC say that > empty envelope addresses must be accepted? Perhaps OpenSMTPD could > substitute the address in the from header as envelope from if it is > empty. > Empty envelope addresses are ... deferred bounces (mailer-daemons), so yes they should definitely be accepted ;-) > OpenSMTPD calls mail.local for mbox delivery. It could be modified to > insert a dummy address if from is empty. I would include a patch, but > I'm not sure that mail.local is the proper place to handle it (or what > dummy address is appropriate). > > Of course mail(1) could also be modified, but that doesn't fix other > clients. > > I'm not sure how this affects sendmail or other mailbox formats. > To answer your questions: mail.local(8) and mail(1) are not the right place for fixing this. mbox format is affected, maildir and external mda aren't as the issue is really about how different MUA expect the mail separator to look like in a mbox. What version of OpenBSD / OpenSMTPD are you using ? We fixed the issue in mid-May before the 5.3.2 stable release and it was merged into OpenBSD by eric@: http://www.openbsd.org/cgi-bin/cvsweb/src/usr.sbin/smtpd/delivery_mbox.c.diff?r1=1.8;r2=1.9;f=h I don't see how your issue could possibly happen with this code :-/ -- Gilles Chehade https://www.poolp.org @poolpOrg
