> >> > hmm, no, that worked for me. did I forget to commit sth?
> >>
> >> Here's the output from systat queues from a test system:
> >>
> >> QUEUE BW SCH PR PKTS BYTES DROP_P DROP_B QLEN BORR SUSP
> >> P/S B/S
> >> root 1G 0 0 0 0 0
> >> regular 1G 69 14428 0 0 0
> >> icmp 1M 10 980 0 0 0
> >>
> >> The P/S and B/S are always blank.
> >
> > ahh, I see. I'll happily admit that I was satisfied as soon as I saw
> > the queues show up with the pkts/bytes counters, the stats reporting is
> > a rather small bit in the entire subsystem and there's only so much
> > your brain can handle at a time.
>
> Understand completely--and pfctl still reports this.
Try this.
The queues only need to be removed from the TAILQ when the ticket
changes.
Index: pftop.c
===================================================================
RCS file: /cvs/src/usr.bin/systat/pftop.c,v
retrieving revision 1.24
diff -u -p -r1.24 pftop.c
--- pftop.c 18 Apr 2014 11:36:06 -0000 1.24
+++ pftop.c 23 Apr 2014 18:56:32 -0000
@@ -1588,10 +1588,6 @@ read_queues(void)
int inserts;
num_disp = num_queues = 0;
- while ((node = TAILQ_FIRST(&qnodes)) != NULL) {
- TAILQ_REMOVE(&qnodes, node, entries);
- free(node);
- }
if (pfctl_update_qstats() < 0)
return (-1);
num_disp = num_queues;
