Hi Jonathan, On Tue 09/12 16:03, Jonathan Gray wrote: > I'm curious why you decided to mask the subid here and not just test > subid == 0x308a103c ?
In my understanding (I'm definitely not an expert), the last part of subid represents the vendor signature (HP in this case); the first 4 digits should be instead specific to the particular chip implementation. Here I just tried to make the patch more general (guessing that the GPIO needs to be unmuted for all IDT 92HD75B1/2-type cards sold by HP), and also to stay close to code style adopted for other (similar?) cases. If my assumption is wrong, then yes, you're right: the whole subid should be tested. Anyhow, thanks for your feedback. All the best -- Alessandro DE LAURENZIS [mailto:[email protected]] LinkedIn: http://it.linkedin.com/in/delaurenzis
