On 02/25/2015 11:53 PM, patrick keshishian wrote:
Hi,
On 2/25/15, joshua stein<j...@openbsd.org> wrote:
On Tue, 24 Feb 2015 at 12:32:10 -0800, patrick keshishian wrote:
I'm noticing slight annoyance with recent update from 20141121
snapshot to 20150217.
My touchpad, while two-finger scrolling (up/down) sometimes ignores
the scrolls. I have to lift my fingers and retry the gesture to initiate
the scroll.
There was a change to pms(4) (r1.57) but it should only affect
elantech touchpads, so it's probably the r1.11 change to the
synaptics xorg driver which affects all of them:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/xenocara/driver/xf86-input-synaptics/src/wsconscomm.c
Can you try recompiling that driver with that last revision backed
out and see if it fixes the problem?
Thanks for the reply and hint.
Took me a while longer as I made the mistake of rebuilding
the entire xenocara.
Indeed this revision seems to be the cause of the issue; at
least I've not been able to run into the issue in the last 10
minutes or so, whilst trying my best.
Thanks to Henrik Friedrichsen for also confirming the issue
and the fix.
Cheers,
--patrick
It might be that the following patch to wsmouse.c solves the problem
with the new version of wsconscomm. Tests would be welcome (I could
only verify that the patch does no harm to other touchpad types, i.e.,
Elantech-v4 and Alps Glidepoint).
Index: wsmouse.c
===================================================================
RCS file: /cvs/src/sys/dev/wscons/wsmouse.c,v
retrieving revision 1.26
diff -u -p -r1.26 wsmouse.c
--- wsmouse.c 27 Oct 2014 13:55:05 -0000 1.26
+++ wsmouse.c 27 Feb 2015 01:39:29 -0000
@@ -420,7 +420,7 @@ wsmouse_input(struct device *wsmousedev,
ev->value = w;
TIMESTAMP;
ADVANCE;
- sc->sc_w = w;
+ sc->sc_w = (sc->sc_z == 0 ? INVALID_W : w);
}
} else {
if (sc->sc_dw) {
