On Thu, Mar 30, 2017 at 07:21:22AM -0400, Jiri B wrote:
> On Thu, Mar 30, 2017 at 12:59:00PM +0200, Bruno Flueckiger wrote:
> > I see your point with the installer. Default labels make the disks
> > indistinguishable. The following diff prints the raw infos from dmesg
> > rather than the current list of disks:
> >
> > Index: distrib/miniroot/install.sub
> > ===================================================================
> > RCS file: /cvs/src/distrib/miniroot/install.sub,v
> > retrieving revision 1.988
> > diff -u -p -r1.988 install.sub
> > --- distrib/miniroot/install.sub 13 Mar 2017 17:08:31 -0000 1.988
> > +++ distrib/miniroot/install.sub 30 Mar 2017 10:44:01 -0000
> > @@ -264,13 +264,7 @@ diskinfo() {
> > local _d
> >
> > for _d; do
> > - make_dev $_d
> > - echo -n "$_d: "
> > - disklabel -dpg $_d 2>/dev/null |
> > - sed -e '/^label: /{s,,,;s/ *$//;s/^$/<no label>/;h;d;}' \
> > - -e '/.*# total bytes: \(.*\)/{s//(\1)/;H;}' \
> > - -e '$!d;x;s/\n/ /'
> > - rm -f /dev/{r,}$_d?
> > + sed -n "/^$_d/p" /var/run/dmesg.boot
> > done
> > }
> >
>
> Your proposition is good for the installer? I doubt it.
>
> j.
AFAICT the function diskinfo() is only called once in the installer: if
you press ? a the prompt for the root disk. So my diff just changes the
output in this case, no other functionality is affected.
What causes your doubt?
