On Sat, Jun 03, 2017 at 01:00:37PM +0300, cho...@jtan.com wrote:
> Job control is disabled prior to setting up the auto-install timeout. It
> is then re-disabled when the timer has been started.
> 
> The second set +m should be set -m or be removed.
> 
>                 # Stop monitoring background processes to avoid printing
>                 # job completion notices in interactive shell mode.  This
>                 # doesn't stop the "[1] <pid>" on starting a job though;
>                 # that's why re redirect stdout and stderr temporarily.
>                 set +m
>                 exec 3<&1 4<&2 >/dev/null 2>&1
>                 (sleep 5; kill $$) &
>                 timer_pid=$!
>                 exec 1<&3 2<&4 3<&- 4<&-
>                 set +m
> 
> Matthew

Job control is never on in the installer as it's a script and the shell
is not in interactive mode, in which case job control would be on by
default. So it's not a bug.

One could argue if it's really necessary to turn monitor mode off in
the first place. But in the case above, the author wanted to make sure
in any case, that it's off at this point.

-- 
-=[rpe]=-

Reply via email to