Henning Brauer wrote:
wait, I think I see a bug and "announce capabilities no" doesn't work :)
please try this diff.
Index: session.c
===================================================================
RCS file: /cvs/src/usr.sbin/bgpd/session.c,v
retrieving revision 1.243
diff -u -p -r1.243 session.c
--- session.c 24 Jan 2006 10:08:16 -0000 1.243
+++ session.c 6 Feb 2006 12:01:08 -0000
@@ -1200,7 +1200,7 @@ session_open(struct peer *p)
if (p->capa.ann.refresh)
op_len += 2 + 0; /* 1 code + 1 len, no data */
- if (op_len > 0)
+ if (p->conf.announce_capa && op_len > 0)
optparamlen = sizeof(op_type) + sizeof(op_len) + op_len;
len = MSGSIZE_OPEN_MIN + optparamlen;
however, after receiving a "Optional Parameter Error" notofcation,
OpenBGPD should quickly retry without any capabilites announced (and thus
optional parameters) on its own. did you wait for the second trial?
Just tried from CVS with the patch applied and still the same :(
I do have what I believe is the open packet as sent to the BD,
unfortunately it's not top drawer at logging these things, logged in hex:
02/06/2006 15:06.21 <DBUG:KERN> 0x08815b0fd0:
00 *
02/06/2006 15:06.21 <DBUG:KERN> 0x08815b0fc0: 00 21 01 04 78 d5 00 5a c1
97 7c 06 04 02 02 02 *!**x**Z**|*****
02/06/2006 15:06.21 <DBUG:KERN> 0x08815b0fb0: ff ff ff ff ff ff ff ff ff
ff ff ff ff ff ff ff ****************
Thanks,
Karl
