Hi Darren,

This got broken when Patrick fixed something related to slow mode for
the Marvel ARMADA 8040 SoC.  The diff below fixes it for me on my
Turris MOX which uses the same SoC.  Not entirely sure what is going
wrong here since looking at the Linux code suggests that Patrick's fix
should work on the ARMADA 3720 as well.

Patrick, should I commit this?  Or do you want to figure out a better
fix?

That BRUME thingy looks cute, but has a bit of an issue.  It doesn't
really have three Ethernet ports.  Instead those ports are part of a
switch that also connects to an Ethernet interface on the SoC.  The
switch can be configured to only allow traffic between certain switch
ports and to do hardware VLAN tagging.  But by default OpenBSD
configures the switch to allow traffic between all ports, which
probably isn't what you want for this particular device.

If you end up playing with this again, eeprom -p output would be
appreciated.

Cheers,

Mark


Index: dev/fdt/sdhc_fdt.c
===================================================================
RCS file: /cvs/src/sys/dev/fdt/sdhc_fdt.c,v
retrieving revision 1.14
diff -u -p -r1.14 sdhc_fdt.c
--- dev/fdt/sdhc_fdt.c  22 Feb 2021 18:55:23 -0000      1.14
+++ dev/fdt/sdhc_fdt.c  1 Apr 2021 22:36:11 -0000
@@ -282,6 +282,8 @@ sdhc_fdt_attach(struct device *parent, s
                if (OF_getproplen(faa->fa_node,
                    "marvell,xenon-phy-slow-mode") == 0)
                        sc->sc_slow_mode = 1;
+               if (OF_is_compatible(faa->fa_node, "marvell,armada-3700-sdhci"))
+                       sc->sc_slow_mode = 1;
 
                sc->sc_znr = OF_getpropint(faa->fa_node,
                    "marvell,xenon-phy-znr", 0xf);

Reply via email to