Hi Jan, Jan Stary wrote on Sat, Nov 06, 2021 at 04:05:10PM +0100: > Ingo Schwarze wrote: >> Jan Stary wrote:
>>> This is current/amd64 on a PC. >>> It seems that if MANPATH is set (to something nonempty), >>> the settings in /etc/man.conf get ignored: >>> >>> $ cat /etc/man.conf >>> output paper a4 >>> >>> $ man -Tps true | grep PageSize >>> %%BeginFeature: *PageSize Letter >>> <</PageSize [612 790]>>setpagedevice >>> >>> $ env | grep MAN >>> MANPATH=/home/hans/man:/usr/local/man:/usr/share/man:/usr/X11R6/man >>> >>> $ export MANPATH= >>> $ man -Tps true | grep Size >>> %%BeginFeature: *PageSize A4 >>> <</PageSize [595 841]>>setpagedevice >> Thanks for reporting. >> >> This seemed like a trivial bug to me, so i fixed it right away in both >> OpenBSD and bsd.lv, see the commit appended below. > thank you for the quick fix. For completeness, > I just confirm it fixes PDF output as well: > > $ man -Tpdf ls | grep Media > /MediaBox [0 0 595 841] Great, thank you for testing. Testing is always highly welcome. >> It turned out to be less trivial than i thought, i ended up completely >> rewriting the manconf_parse() function. Yes, i am aware that other bug >> reports against mandoc are still pending, and i'm a bit behind, you just >> got lucky that this one *seemed* simple at first... "That is probably >> easy to do with a three-line diff..." > Point taken: always make sure the bug seems trivial > so that it gets up the list :-) LOL. :-D Then again, it's not that far from the truth. The best bug reports are those making it trivial for developers to understand what is going on. Your report was exemplary, stating very clearly and concisely what you did, what you expected, and what happened instead, without any additional fuss. Yours, Ingo
