Hi Lyndon, Lyndon Nerenberg wrote on Fri, Apr 22, 2022 at 09:33:57AM -0700:
> In the output from the daily insecurity report run, the sections on > setuid and block device changes are missing any diff markup. The > remaining sections are fine. > > From this morning's post-7.1-upgrade run: > > Setuid changes: > -r-sr-xr-x 2 root bin 355952 Sep 30 13:01:03 2021 /sbin/ping > -r-sr-xr-x 2 root bin 358736 Apr 11 16:46:17 2022 /sbin/ping > -r-sr-xr-x 2 root bin 355952 Sep 30 13:01:03 2021 /sbin/ping6 > -r-sr-xr-x 2 root bin 358736 Apr 11 16:46:17 2022 /sbin/ping6 > -r-sr-x--- 1 root operator 274936 Sep 30 13:01:04 2021 /sbin/shutdown > -r-sr-x--- 1 root operator 277592 Apr 11 16:46:17 2022 /sbin/shutdown > [...] > > > Block device changes: > brw-r----- 1 root operator 6, 0 Mar 4 14:48:06 2022 /dev/cd0a > brw-r----- 1 root operator 6, 0 Apr 21 12:19:45 2022 /dev/cd0a > brw-r----- 1 root operator 6, 2 Mar 4 14:48:06 2022 /dev/cd0c > brw-r----- 1 root operator 6, 2 Apr 21 12:19:45 2022 /dev/cd0c > brw-r----- 1 root operator 6, 16 Mar 4 14:48:01 2022 /dev/cd1a > brw-r----- 1 root operator 6, 16 Apr 21 12:19:40 2022 /dev/cd1a > [...] That's not new, it has been like that for at least 14 years and likely much longer: From: Charlie Root <[email protected]> Date: Sun, 27 Apr 2008 01:31:15 +0200 To: [email protected] Subject: hera.usta.de daily insecurity output [...] Setuid changes: -r-sr-xr-x 1 root bin 157408 Feb 11 00:00:58 2008 /sbin/ping -r-sr-xr-x 1 root bin 157440 Apr 21 02:58:12 2008 /sbin/ping -r-sr-xr-x 1 root bin 180896 Apr 21 02:58:12 2008 /sbin/ping6 -r-sr-xr-x 1 root bin 181024 Feb 11 00:00:58 2008 /sbin/ping6 [...] Block device changes: brw-r----- 1 root operator 16, 0 Apr 26 21:21:20 2008 /dev/ccd0a brw-r----- 1 root operator 16, 0 Feb 16 18:24:18 2008 /dev/ccd0a brw-r----- 1 root operator 16, 1 Apr 26 21:21:20 2008 /dev/ccd0b brw-r----- 1 root operator 16, 1 Feb 16 18:24:18 2008 /dev/ccd0b [...] Which means my 2011 rewrite of the utility (together with afresh1@) merely preserved the traditional format. These lines do not come from diff(1); see the functions check_filelist() and adjust_columns() for details. I don't think adding the more characters to each line would be a good idea. It would cause line wrapping in mail even more often than the long lines already do now. Besides, there is no real ambiguity because the file name in the last column makes the pairing obvious and the dates right in front of that show the direction of the change. Yours, Ingo
