At last, I want to note that the switch structures in sftp.c and ssh.c
related with getopt(3) can be reordered.  Currently, its order is
very difficult to understand, at least for me.  (perhaps my patch does
not put the "case 'l':" in the right place for that reason, beware!)
and there are some indentation/formatting issues.  For example, ssh.c
adds blank lines between "cases" after the

                case 'l':
                        options.user = optarg;
                        break;

I think that these lines should not be here.  Don't know if it is the
right format for the case structure, but looks wrong to me.

There are other fprintf() functions that can be improved as I did in
the first patches (not related with the implementatio of "-l" in sftp).

Best wishes,
Igor.

Reply via email to