On Mon, Jan 29, 2007 at 10:00:51PM +0100, Igor Sobrado wrote: > > Changes introduced by this patch: > > - adds three spaces after the tab character to improve readability > of the usage message.
i prefer just to use a single tab to start a new line. otherwise we end up with lots of usage() functions containing mad amounts of tabs and spaces, potentially in need of adjustment when things change. > - removes the "f" option in "-safe", it seems that the argument > to "-f" is not optional. see my last mail about that. > - removes the case for "m", that is now managed by the default case: > > # awk -mr > awk: unknown option -mr ignored > > awk: no program given > hmm, i don;t see the harm of flagging these as obsoleted...the output is very similar whatever way you do it, and at least this way people used to the old behaviour get a little more warning. additionally i confess to a little mix up ;) i totally forgot that awk is maintained 3rd party when i made my changes. tut tut. in general it is better if we send fixes upstream and later import them. sometimes we keep local changes, but generally it is desirable to minimise those. jmc
