On Fri, Jan 04, 2008 at 01:00:19AM +0100, Kim Naim Lesmer wrote:
> Hi.
>
> This is just a small diff for cp.c I believe it will improve
> readability a little bit.
>
> Regards.
>
> Sorry, the diff goes here:
>
> --- cp.c 2008-01-04 00:26:09.000000000 +0100
> +++ cp_new.c 2008-01-04 00:28:48.000000000 +0100
> @@ -215,8 +215,9 @@
> type = DIR_TO_DNE;
> else
> type = FILE_TO_FILE;
> - } else
> + } else {
> type = FILE_TO_FILE;
> + }
> } else {
> /*
> * Case (2). Target is a directory.
>
>
No, see style(9) for examples. Single statements in if/else/for/while/etc
constructs don't need curly braces.
It's not recommended to send single stylistic changes, unless you also
fix/improve other things. It wastes the developers time because they
have to proofread your diff. That proof reading takes about the same
time as "fixing" it by themselves, so do the math...
Tobias
