On Mon, Jan 07, 2008 at 03:31:37PM +0100, giovanni wrote: > On Mon, Jan 07, 2008 at 07:43:56AM -0600, Marco Peereboom wrote: > > Nope, I added it in there exactly that way. I got the idea from FreeBSD > Sorry, but in your diff TC1 and TC2 are not debounced. right? so why am I > wrong?
They are not temperatures; they are static values. Temperatures can come from the BMC and might be corrupted so you read them a few more times to make sure they are correct. Static values do not need this since they come directly from memory. > > >I got the idea from FreeBSD > ehm I sent you something similar a while ago but you will not answer ;) I am CC'ing misc because I answered it there too. > > > > > > Thanks for the diff though. Keep them coming. > > > > On Mon, Jan 07, 2008 at 11:52:24AM +0100, giovanni wrote: > > > I've have two more values that maybe should be debounced: > > > > > > _AC0 = 2732 > > > _TC1 = 1 > > > _TC2 = 5 > > > > > > Index: acpitz.c > > > =================================================================== > > > RCS file: /cvs/src/sys/dev/acpi/acpitz.c,v > > > retrieving revision 1.21 > > > diff -u -r1.21 acpitz.c > > > --- acpitz.c 6 Jan 2008 18:06:50 -0000 1.21 > > > +++ acpitz.c 7 Jan 2008 10:49:58 -0000 > > > @@ -124,8 +124,8 @@ > > > } > > > > > > sc->sc_hot = acpitz_gettempreading(sc, "_HOT"); > > > - sc->sc_tc1 = acpitz_getreading(sc, "_TC1"); > > > - sc->sc_tc2 = acpitz_getreading(sc, "_TC2"); > > > + sc->sc_tc1 = acpitz_gettempreading(sc, "_TC1"); > > > + sc->sc_tc2 = acpitz_gettempreading(sc, "_TC2"); > > > sc->sc_psv = acpitz_gettempreading(sc, "_PSV"); > > > dnprintf(10, "%s: _HOT: %d _TC1: %d _TC2: %d _PSV: %d _TMP: %d " > > > "_CRT: %d\n", DEVNAME(sc), sc->sc_hot, sc->sc_tc1, sc->sc_tc2, > > > > > > > > > acpitz0 at acpi0: critical temperature 105 degC > > > acpitz0: TZ00: failed to read _AC0 > > > acpitz0: TZ00: failed to read _TC1 > > > acpitz0: TZ00: failed to read _TC2 > > > acpitz1 at acpi0: critical temperature 105 degC > > > acpitz1: TZ01: failed to read _AC0 > > > acpitz1: TZ01: failed to read _TC1 > > > acpitz1: TZ01: failed to read _TC2 > > > > > > -- > > > see ya, > > > giovanni > > > > > -- > see ya, > giovanni
